fix: consolidate duplicate TransactionPagination into single correct implementation#230
Merged
portableDD merged 1 commit intoJun 25, 2026
Conversation
|
@Hollujay is attempting to deploy a commit to the Emmanuel Dorcas' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Hollujay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Olasunkanmi975
pushed a commit
to Olasunkanmi975/NexaFx-web
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
📝 Context
The previous transaction pagination component had a hardcoded layout ( 1, 2, 3, 4, 5 ... ) and lacked proper
state-driven navigation for large datasets. This made it difficult for users to navigate effectively when they
have many pages of transactions.
🚀 What changed
This PR updates the TransactionPagination component to introduce dynamic ellipsis-based pagination, along with
UI enhancements:
• Dynamic Page Calculation: Implemented getVisiblePages() to dynamically calculate and render page numbers with
ellipses ( ... ) based on the current page and total pages (e.g., 1 ... 4 5 6 7 8 ... 12 ).
• Icon Updates: Replaced text-based "Previous" and "Next" buttons with ChevronLeft and ChevronRight icons
from lucide-react for a cleaner, modern look.
• Improved Styling:
• Updated buttons with proper active, hover, and disabled states (e.g., cursor not-allowed when on the first
or last page).
• Aligned the layout so that "Showing {start} to {end} of {total} results" sits nicely on the left (or on top
for mobile screens), and the pagination controls sit on the right.
• Refined the active state to use the primary theme color.
📸 Screenshots
🧪 How to test
end of the list.
Closes #154