feat: Wire Convert form to live API and replace MOCK data#191
Merged
portableDD merged 2 commits intoJun 11, 2026
Merged
Conversation
|
@AbuJulaybeeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@AbuJulaybeeb please resolve ci error, ci must be successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createSwap()tolib/api/transactions.tsto callPOST /transactions/swap.MOCK_RATESwith live exchange rate data fetched viaGET /api/exchange-rates, adding a fallback error state for 500 errors or failures.MOCK_BALANCESwith real data using thegetBalances()function fromlib/api/wallet.ts.disabled={true}from the submit button and connected the form tocreateSwap(), handling loading, success, and error states gracefully.Why it was done
The Convert form was completely non-functional, utilizing hardcoded mock data and an inactive submit button. This change activates the core conversion functionality by integrating with the live backend APIs, enabling users to actually swap currencies based on active rates.
How it was verified
getBalances().POST /transactions/swapwith the correct payload on submission.createSwap().Closes [Wave 200pts] Feature: Wire Convert form to live API — replace MOCK_RATES/MOCK_BALANCES and enable the disabled submit button #170