Skip to content

chore: delete orphaned mock files (transactions, mock-data, mock-noti…#190

Merged
portableDD merged 1 commit into
Nexacore-Org:mainfrom
IyanuOluwaJesuloba:main
Jun 1, 2026
Merged

chore: delete orphaned mock files (transactions, mock-data, mock-noti…#190
portableDD merged 1 commit into
Nexacore-Org:mainfrom
IyanuOluwaJesuloba:main

Conversation

@IyanuOluwaJesuloba

@IyanuOluwaJesuloba IyanuOluwaJesuloba commented May 31, 2026

Copy link
Copy Markdown
Contributor

Closes #176


📌 Pull Request Title

📋 Description

Removes three orphaned files identified in the API audit. None were imported by any active page or component, and leaving them posed a maintenance risk - a future contributor could accidentally import from the wrong path and introduce hard-to-debug mock data bugs.

🛠 Changes Implemented

Files deleted

transactions.ts - duplicate of
transactions.ts
with a setTimeout stub, hardcoded mock data, and a conflicting Transaction type ('Completed'/'Cancelled' vs the real file's 'Success'/'Failed')
mock-notifications.ts -10 hardcoded Notification objects, not imported anywhere
mock-data.ts - marked @deprecated in its own JSDoc, exported mockTransactions: never[], not imported anywhere meaningfully

✅ How to Test

  1. Setup: Steps to set up the environment.
  2. Run Tests: Instructions to verify the changes.
  3. Expected Output: What should happen if the changes work correctly.

🔍 Screenshots (if applicable)

Attach screenshots or GIFs to show visual changes.

🚀 Checklist

  • Code follows project style guidelines.
  • Changes are tested and verified.
  • Documentation is updated (if needed).

🔗 Related Issues

  • Closes #<ISSUE_NUMBER>
  • Resolves #<ISSUE_NUMBER>
  • Fixes #<ISSUE_NUMBER>

@drips-wave

drips-wave Bot commented May 31, 2026

Copy link
Copy Markdown

@IyanuOluwaJesuloba Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@portableDD portableDD merged commit b14427a into Nexacore-Org:main Jun 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wave 100pts] Cleanup: Delete 3 orphaned files — app/lib/api/transactions.ts, lib/mock-notifications.ts, lib/mock-data.ts

2 participants