-
Notifications
You must be signed in to change notification settings - Fork 45
Update feature_request.yml #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for creating a PR for your Issue!
|
Summary of ChangesHello @neeru24, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the feature request issue template to streamline the submission process and improve the quality of incoming requests. By enforcing a more structured format, clarifying field descriptions, and making key information mandatory, the changes aim to ensure that all necessary details are provided upfront, facilitating better evaluation and management of new features. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the feature request template by enforcing a better structure, adding clearer wording with helpful icons and placeholders, and making key fields mandatory. The addition of a confirmation checkbox to prevent duplicate requests is also a valuable improvement. My only suggestion is to reconsider making the 'Additional Context' field mandatory, as it may not always be applicable for every feature request. Overall, these changes will lead to higher quality feature submissions.
| placeholder: Screenshots, diagrams, references, etc. | ||
| validations: | ||
| required: false | ||
| required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While making most fields required improves the quality of feature requests, making additional_context mandatory might be overly strict. Users may not always have mockups, screenshots, or other context to add, especially for straightforward feature requests. Forcing them to fill this field could lead to them simply entering 'N/A' or similar, which doesn't add value. Consider making this field optional to improve the user experience when submitting a feature request.
required: false
I’ve enforced better structure, clearer wording, and mandatory fields where it matters
@abhishek-nexgen-dev fixes #133