Dev - #48
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ilities Feature: Fix Dependabot Vulnerabilities
There was a problem hiding this comment.
Code Review
This pull request introduces a Dependabot configuration for automated dependency updates across npm, Cargo, and GitHub Actions. It also updates package.json by adding security audit scripts, removing an unused shell dependency, and implementing dependency overrides for several packages. Feedback identifies that the ip-address version specified in the overrides does not exist and that the overrides block should be nested under a pnpm key for correct behavior. Additionally, the pnpm audit script uses an unsupported flag, and there is a noted inconsistency between the use of pnpm and the presence of an npm package-lock.json file.
| "overrides": { | ||
| "ip-address": "^10.1.1", | ||
| "semver": "^7.5.4", | ||
| "braces": "^3.0.3", | ||
| "micromatch": "^4.0.8" | ||
| } |
There was a problem hiding this comment.
The version ^10.1.1 for ip-address does not appear to exist on the public npm registry (the current latest stable version is 10.0.1), which will cause installation failures. Furthermore, since the project scripts use pnpm, it is best practice to define dependency overrides under the pnpm.overrides key rather than the top-level overrides key used by npm.
"pnpm": {
"overrides": {
"ip-address": "^10.0.1",
"semver": "^7.5.4",
"braces": "^3.0.3",
"micromatch": "^4.0.8"
}
}| "format": "prettier . --write --ignore-unknown", | ||
| "format:check": "prettier . --check --ignore-unknown" | ||
| "format:check": "prettier . --check --ignore-unknown", | ||
| "audit": "pnpm audit --prod --audit-level high", |
There was a problem hiding this comment.
The pnpm audit command does not support a --prod flag. If the intention is to audit only production dependencies, you should use the --no-optional flag or ensure you are using a version of pnpm that supports this specific filtering. Additionally, there is an inconsistency between the use of pnpm in these scripts and the presence of a package-lock.json file in the repository, which is specific to npm. It is recommended to use a single package manager consistently.
No description provided.