Skip to content

Dev - #48

Merged
abhishek-nexgen-dev merged 4 commits into
masterfrom
dev
May 8, 2026
Merged

Dev#48
abhishek-nexgen-dev merged 4 commits into
masterfrom
dev

Conversation

@abhishek-nexgen-dev

Copy link
Copy Markdown
Member

No description provided.

vivek0028 and others added 4 commits May 7, 2026 02:02
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ilities

Feature: Fix Dependabot Vulnerabilities
@abhishek-nexgen-dev
abhishek-nexgen-dev merged commit 6eee84f into master May 8, 2026
1 of 3 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Dependabot configuration for automated dependency updates across npm, Cargo, and GitHub Actions. It also updates package.json by adding security audit scripts, removing an unused shell dependency, and implementing dependency overrides for several packages. Feedback identifies that the ip-address version specified in the overrides does not exist and that the overrides block should be nested under a pnpm key for correct behavior. Additionally, the pnpm audit script uses an unsupported flag, and there is a noted inconsistency between the use of pnpm and the presence of an npm package-lock.json file.

Comment thread package.json
Comment on lines +64 to 69
"overrides": {
"ip-address": "^10.1.1",
"semver": "^7.5.4",
"braces": "^3.0.3",
"micromatch": "^4.0.8"
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version ^10.1.1 for ip-address does not appear to exist on the public npm registry (the current latest stable version is 10.0.1), which will cause installation failures. Furthermore, since the project scripts use pnpm, it is best practice to define dependency overrides under the pnpm.overrides key rather than the top-level overrides key used by npm.

  "pnpm": {
    "overrides": {
      "ip-address": "^10.0.1",
      "semver": "^7.5.4",
      "braces": "^3.0.3",
      "micromatch": "^4.0.8"
    }
  }

Comment thread package.json
"format": "prettier . --write --ignore-unknown",
"format:check": "prettier . --check --ignore-unknown"
"format:check": "prettier . --check --ignore-unknown",
"audit": "pnpm audit --prod --audit-level high",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pnpm audit command does not support a --prod flag. If the intention is to audit only production dependencies, you should use the --no-optional flag or ensure you are using a version of pnpm that supports this specific filtering. Additionally, there is an inconsistency between the use of pnpm in these scripts and the presence of a package-lock.json file in the repository, which is specific to npm. It is recommended to use a single package manager consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants