Reduce necessary database privileges #896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebbo94BY
commented
Jul 9, 2023
Sebbo94BY
commented
- Avoid the usage of "SHOW DATABASES" as this requires global privileges, which a restricted database user will not have in best case. The application should not be potentially able to see other databases on the host.
- Avoid the usage of "DROP DATABASE" as an application should never delete itself. This also ensures, that the application does not accidently delete all data.
- "CREATE DATABASE" only if it not exists yet. This ensures, that the application can create the database, if it does not exist yet, but it will not fail, if it already exists.
- If the database already has the necessary tables, the following SQL statements will fail, so the "if database exists" check is not necessary.
- Avoid the usage of "SHOW DATABASES" as this requires global privileges, which a restricted database user will not have in best case. The application should not be potentially able to see other databases on the host. - Avoid the usage of "DROP DATABASE" as an application should never delete itself. This also ensures, that the application does not accidently delete all data. - "CREATE DATABASE" only if it not exists yet. This ensures, that the application can create the database, if it does not exist yet, but it will not fail, if it already exists. - If the database already has the necessary tables, the following SQL statements will fail, so the "if database exists" check is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.