Skip to content

[Refactor] #52 - 서비스 계층 책임 분리 및 DTO 생성 일관성 향상 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haeun1107 merged 2 commits into from
Jul 13, 2025
Merged

[Refactor] #52 - 서비스 계층 책임 분리 및 DTO 생성 일관성 향상 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
070ec52
[Refactor] #52 - 디폴트 응답 COMMON_SUCCESS 삭제
haeun1107 Jul 13, 2025
5b2438a
[Refactor] #52 - 생성자 호출 대신 converter 사용
haeun1107 Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/dgu/newsee/domain/news/converter/NewsConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@
import dgu.newsee.domain.crawlednews.entity.NewsOrigin;
import dgu.newsee.domain.news.dto.NewsDetailDTO;
import dgu.newsee.domain.news.dto.NewsDTO;
import dgu.newsee.domain.news.dto.SaveNewsResponseDTO;
import dgu.newsee.domain.news.dto.SavedNewsDTO;
import dgu.newsee.domain.news.entity.SavedNews;
import dgu.newsee.domain.transformednews.entity.NewsTransformed;
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;
import lombok.NoArgsConstructor;

import java.util.List;

Expand Down Expand Up @@ -64,4 +69,11 @@ public static NewsDetailDTO toNewsDetailDto(
.keywords(keywords)
.build();
}

public static SaveNewsResponseDTO toSaveNewsResponseDto(Long userId, SavedNews savedNews) {
return SaveNewsResponseDTO.builder()
.userId(userId)
.savedNewsId(savedNews.getId())
.build();
}
}
2 changes: 2 additions & 0 deletions src/main/java/dgu/newsee/domain/news/dto/SaveNewsResponseDTO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package dgu.newsee.domain.news.dto;

import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;

@Builder
@Getter
@AllArgsConstructor
public class SaveNewsResponseDTO {
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/dgu/newsee/domain/news/service/NewsServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public ApiResponse<List<NewsDTO>> getAllNews(Long userId, String levelKor) {
})
.collect(Collectors.toList());

return ApiResponse.success(dtos, ResponseCode.COMMON_SUCCESS);
return ApiResponse.success(dtos);
}

@Override
Expand Down Expand Up @@ -92,7 +92,7 @@ public ApiResponse<NewsDetailDTO> getNewsDetail(Long newsId, Long userId, String
keywordDtos
);

return ApiResponse.success(dto, ResponseCode.COMMON_SUCCESS);
return ApiResponse.success(dto);
}

@Override
Expand Down Expand Up @@ -149,7 +149,7 @@ public ApiResponse<?> saveNews(Long userId, Long newsId, String levelKor) {
savedNewsRepository.save(savedNews);

return ApiResponse.success(
new SaveNewsResponseDTO(userId, savedNews.getId()),
NewsConverter.toSaveNewsResponseDto(userId, savedNews),
ResponseCode.NEWS_SAVE_SUCCESS
);
}
Expand All @@ -171,7 +171,7 @@ public ApiResponse<List<SavedNewsDTO>> getSavedNews(Long userId, String levelKor
})
.collect(Collectors.toList());

return ApiResponse.success(dtos, ResponseCode.COMMON_SUCCESS);
return ApiResponse.success(dtos);
}


Expand All @@ -186,7 +186,7 @@ public ApiResponse<?> deleteNewsBookmark(Long userId, Long savedNewsId) {

savedNewsRepository.delete(savedNews);

return ApiResponse.success(null, ResponseCode.COMMON_SUCCESS);
return ApiResponse.success(null);
}


Expand Down