Skip to content

Allow custom output directory for downloaded plugins and builds. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NewAmazingPVP merged 2 commits into from
Oct 14, 2025
Merged

Allow custom output directory for downloaded plugins and builds. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80498b5
Allow custom output directory for downloaded plugins and builds.
TubYoub Sep 25, 2025
a52c981
Improve custom path sanitization and user home expansion
NewAmazingPVP Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 68 additions & 12 deletions src/main/java/common/PluginDownloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.net.URL;
import java.nio.charset.StandardCharsets;
import java.nio.file.*;
import java.nio.file.InvalidPathException;
import java.nio.file.attribute.BasicFileAttributes;
import java.security.DigestInputStream;
import java.security.MessageDigest;
Expand Down Expand Up @@ -126,6 +127,10 @@ public X509Certificate[] getAcceptedIssuers() {
}

public boolean downloadPlugin(String link, String fileName, String githubToken) throws IOException {
return downloadPlugin(link, fileName, githubToken, null);
}

public boolean downloadPlugin(String link, String fileName, String githubToken, String customPath) throws IOException {
String host = null;
Semaphore hostSem = null;
try {
Expand All @@ -145,7 +150,7 @@ public boolean downloadPlugin(String link, String fileName, String githubToken)

String tempBase = UpdateOptions.tempPath != null && !UpdateOptions.tempPath.isEmpty() ? ensureDir(UpdateOptions.tempPath) : "plugins/";
String rawTempPath = tempBase + fileName + ".download.tmp";
String outputFilePath = getString(fileName);
String outputFilePath = resolveOutputPath(fileName, customPath);
String outputTempPath = outputFilePath + ".temp";

try {
Expand Down Expand Up @@ -287,37 +292,79 @@ private String getString(String fileName) {
String configuredFilePath = UpdateOptions.filePath;
String configuredUpdatePath = UpdateOptions.updatePath;


if (configuredFilePath != null && !configuredFilePath.isEmpty()) {
return ensureDir(configuredFilePath) + fileName + ".jar";
}


File mainJar = new File(basePlugins + fileName + ".jar");


if (UpdateOptions.useUpdateFolder) {

String updateDir = (configuredUpdatePath != null && !configuredUpdatePath.isEmpty())
? ensureDir(configuredUpdatePath)
: ensureDir(basePlugins + "update/");


if (mainJar.exists()) {
return updateDir + fileName + ".jar";
} else {
return basePlugins + fileName + ".jar";
}
}


return basePlugins + fileName + ".jar";
}

private String resolveOutputPath(String fileName, String customPath) {
if (customPath != null && !customPath.trim().isEmpty()) {
String cp = sanitizeCustomPath(customPath);
if (cp != null && !cp.isEmpty()) {
String dir = ensureDir(cp);
return dir + fileName + ".jar";
}
}
return getString(fileName);
}

private String sanitizeCustomPath(String cp) {
if (cp == null) return null;
cp = cp.trim();
if (cp.isEmpty()) return null;
cp = expandUserHome(cp);
try {
Path path = Paths.get(cp).normalize();
String normalized = path.toString();
return normalized.isEmpty() ? null : normalized;
} catch (InvalidPathException ex) {
if (UpdateOptions.debug) {
logger.info("[DEBUG] Ignoring custom path '" + cp + "' due to invalid path: " + ex.getMessage());
}
return null;
}
}

private String expandUserHome(String path) {
if (path == null || !path.startsWith("~")) {
return path;
}
String home = System.getProperty("user.home");
if (home == null || home.isEmpty()) {
return path;
}
if (path.equals("~")) {
return home;
}
if (path.startsWith("~/") || path.startsWith("~\\")) {
return home + path.substring(1);
}
return path;
}

private String ensureDir(String dir) {
if (!dir.endsWith("/") && !dir.endsWith("\\")) dir = dir + "/";
new File(dir).mkdirs();
return dir;
if (dir == null || dir.isEmpty()) return dir;
File directory = new File(dir);
directory.mkdirs();
String path = directory.getPath();
if (!path.endsWith(File.separator)) path = path + File.separator;
return path;
}

private boolean downloadPluginToFile(String outputFilePath, HttpURLConnection connection) throws IOException {
Expand Down Expand Up @@ -354,9 +401,13 @@ private boolean extractFirstJarFromZip(String zipFilePath, String outputFilePath
}

public boolean downloadJenkinsPlugin(String link, String fileName) {
return downloadJenkinsPlugin(link, fileName, null);
}

public boolean downloadJenkinsPlugin(String link, String fileName, String customPath) {
String tempBase = UpdateOptions.tempPath != null && !UpdateOptions.tempPath.isEmpty() ? ensureDir(UpdateOptions.tempPath) : "plugins/";
String rawTempPath = tempBase + fileName + ".download.tmp";
String outputFilePath = getString(fileName);
String outputFilePath = resolveOutputPath(fileName, customPath);
String outputTempPath = outputFilePath + ".temp";
HttpURLConnection seedConnection;
try {
Expand Down Expand Up @@ -867,6 +918,10 @@ private boolean downloadLenient(File outFile, HttpURLConnection connection) {


public boolean buildFromGitHubRepo(String repoPath, String fileName, String key) throws IOException {
return buildFromGitHubRepo(repoPath, fileName, key, null);
}

public boolean buildFromGitHubRepo(String repoPath, String fileName, String key, String customPath) throws IOException {
if (repoPath == null || repoPath.isEmpty()) throw new IOException("Invalid repo path");
if (UpdateOptions.debug) logger.info("[DEBUG] Starting GitHub build for " + repoPath);

Expand Down Expand Up @@ -982,7 +1037,8 @@ public boolean buildFromGitHubRepo(String repoPath, String fileName, String key)
}


File out = new File("plugins/update/" + fileName + ".jar");
String outputFilePath = resolveOutputPath(fileName, customPath);
File out = new File(outputFilePath);
if (UpdateOptions.debug) logger.info("[DEBUG] Built jar selected: " + jar.getAbsolutePath());
copyFile(jar, out);
return true;
Expand Down
Loading