-
Notifications
You must be signed in to change notification settings - Fork 91
Fix invalid CSS properties breaking assistant toggle on wide displays #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rly <[email protected]>
Copilot
AI
changed the title
[WIP] Fix floating open/close assistant tab for wider displays
Fix invalid CSS properties breaking assistant toggle on wide displays
Dec 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2151 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 29 29
Lines 2876 2876
Branches 740 740
=======================================
Hits 2739 2739
Misses 83 83
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Co-authored-by: rly <[email protected]>
Contributor
Author
rly
approved these changes
Dec 11, 2025
stephprince
reviewed
Dec 12, 2025
stephprince
reviewed
Dec 12, 2025
stephprince
reviewed
Dec 12, 2025
stephprince
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The assistant toggle button was not properly positioned on displays ≥1400px due to invalid CSS properties
max-margin-rightandmax-rightin the media query for large screens.How to test the behavior?
cd docs && make htmldocs/_build/html/index.htmlin a browserOr test on the live dev docs at https://pynwb.readthedocs.io/en/dev/
Changes
Before: Used invalid CSS properties that browsers ignore
After: Use CSS
min()function for proper constraintApplied same fix to
width,margin-right, andrightproperties in the@media (min-width: 1400px)query.Screenshots
1600px viewport - dynamic sizing:

2000px viewport - capped at 600px:

Checklist
ruff check . && codespellfrom the source directory.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.