feat(checks): add check_subject_weight to validate weight format #647
+104
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new check that ensures subject weight follows the form '[numeric] [unit]' (e.g., '2.3 kg' or '25kg'). Without a unit, the weight is ambiguous. - Add weight_form_regex pattern for validation - Register check with CRITICAL importance - Add unit tests for valid/invalid weight formats Closes #370
Add documentation for the subject weight field format requirement. The weight should follow '[numeric] [unit]' format (e.g., '2.3 kg') to avoid ambiguity. References the check_subject_weight validation function.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #647 +/- ##
==========================================
+ Coverage 77.41% 80.40% +2.99%
==========================================
Files 47 47
Lines 1656 1664 +8
==========================================
+ Hits 1282 1338 +56
+ Misses 374 326 -48
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new check that ensures subject weight follows the form '[numeric] [unit]' (e.g., '2.3 kg' or '25kg'). Without a unit, the weight is ambiguous.
Closes #370