[New Check]: Add check electricalseries of dtype int16 #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandratrapani
added
the
category: new check
Co-authored-by: Cody Baker <[email protected]>
Co-authored-by: Cody Baker <[email protected]>
Co-authored-by: Cody Baker <[email protected]>
CodyCBakerPhD
changed the title
Contributor
|
Just occurred to me while inspecting some files on the GUIDE; we should also consider the If the attribute exists, and the elements of it are not also |
bendichter
added a commit
that referenced
this pull request
Dec 24, 2025
Add `check_electrical_series_unscaled_data` to warn when ElectricalSeries has integer data type with default conversion (1.0) and offset (0.0), which suggests raw acquisition units are not properly scaled to Volts. The check also considers `channel_conversion` for per-channel scaling to avoid false positives when proper conversion factors are specified. Includes documentation for the best practice and changelog entry. Closes #408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #395
Add check on ElectricalSeries data type: if the conversion and offset are DEFAULT values and the data type is any integer ("uint16", "int16", etc).