Skip to content

Conversation

samkitshah1262
Copy link

@samkitshah1262 samkitshah1262 commented Jan 16, 2025

towards #433 , @sanjayankur31 , could you please take a look and provide feedback. Thank you !

@samkitshah1262 samkitshah1262 changed the title utility function list params in ComponentType [WIP] utility function list params in ComponentType Jan 16, 2025
@sanjayankur31 sanjayankur31 self-requested a review January 22, 2025 13:25
@sanjayankur31 sanjayankur31 self-assigned this Jan 22, 2025
@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Jan 22, 2025
@sanjayankur31
Copy link
Member

@samkitshah1262 : could you add a unit test too please? It just makes it easier to test + verify?

@samkitshah1262
Copy link
Author

ready for review

@sanjayankur31
Copy link
Member

sanjayankur31 commented Feb 27, 2025

Hi @samkitshah1262 , thanks for this and sorry for the delay. it's a good start, but it's incomplete because every NeuroML class is actually a "ComponentType":

https://docs.neuroml.org/Userdocs/LEMS_elements/Definingcomponenttypes.html

and example:

https://github.com/NeuroML/NeuroML2/blob/master/NeuroML2CoreTypes/Cells.xml#L1298

So, one has to load the model in LEMS (using PyLEMS) and then in the LEMS representation, go through all the component types to list their parameters

https://github.com/LEMS/pylems/

(I do want to note that we're not putting forward a GSoC project this year related to developing NeuroML software like we did last year, so if you're looking for GSoC projects, you may want to look at the other options).

@samkitshah1262
Copy link
Author

@sanjayankur31 Thank you for the review and the heads up! Was looking for GSOC project primarily, nevertheless I would love to contribute! Moreover, is there a collaboration space (except gitter) , If not a dedicated contributor channel for communication?

@sanjayankur31
Copy link
Member

@sanjayankur31 Thank you for the review and the heads up! Was looking for GSOC project primarily, nevertheless I would love to contribute! Moreover, is there a collaboration space (except gitter) , If not a dedicated contributor channel for communication?

Most of our collaboration happens here over GitHub, and the element/matrix (which used to be gitter) channel is where folks chat if something requires synchronous communication.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in NeuroML backlog Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: enhancement Type: enhancement
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants