Integrate zerocopy - #42
Merged
Merged
Conversation
frozenspider
marked this pull request as ready for review
August 3, 2026 11:23
frozenspider
requested review from
NiDimi,
cupicmarko and
maksimryndin
as code owners
August 3, 2026 11:23
zkfriendly
requested changes
Aug 4, 2026
zkfriendly
left a comment
zkfriendly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR, had a minor point and comment:
The new tests are gated by feature = "zerocopy", but the build-and-test workflow runs only the default feature set, where zerocopy is disabled.
Collaborator
Author
|
Thanks @zkfriendly, nice catch! Both concerns were addressed - although there's no CI workflow for now that can catch this feature combination |
zkfriendly
approved these changes
Aug 4, 2026
zkfriendly
left a comment
zkfriendly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for addressing concerns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive
zerocopytraits for sets (semirings, rings and fields).Unfortunately, we can only meaningfully derive them for our own
BooleanandF2types, for the rest we only deriveKnownLayout.(As a future note, dynamic field elements shouldn't derive
FromBytesas using it on invalid bit pattern might lead to soundness gaps)While we're at it, also moved trivial forward implementation of
Zeroizetoderiveapproach