Skip to content

Conversation

@fmayer
Copy link

@fmayer fmayer commented Feb 1, 2025

In fact, it is always WIN_ERR in the caller in line 1403

This tripped UBSan's bounds checks

In fact, it is always WIN_ERR in the caller in line 1403

This tripped UBSan's bounds checks
@heiner
Copy link
Collaborator

heiner commented Feb 1, 2025

Note that we inherited this drastic issue from upstream NetHack https://github.com/NetHack/NetHack/blob/NetHack-3.6/win/tty/wintty.c#L1558

@heiner
Copy link
Collaborator

heiner commented Feb 1, 2025

But 3.7 fixed the same issue: NetHack/NetHack@f9d7bc6

@fmayer
Copy link
Author

fmayer commented Feb 3, 2025

Hmm, CI crashed with this:

    gmake[2]: *** [dat/earth.lev] Segmentation fault (core dumped)
    gmake[2]: *** Deleting file `dat/earth.lev'
    gmake[2]: *** Waiting for unfinished jobs....
    gmake[1]: *** [dat/CMakeFiles/dat.dir/all] Error 2
    gmake[1]: *** Waiting for unfinished jobs....

@heiner
Copy link
Collaborator

heiner commented Feb 3, 2025

@StephenOman do you have any context on this?

@StephenOman
Copy link
Collaborator

Not yet. Doesn't look related to this PR. Error is:

gmake[2]: *** [dat/earth.lev] Segmentation fault (core dumped)

@StephenOman StephenOman added the bug Something isn't working label Feb 9, 2025
@fmayer
Copy link
Author

fmayer commented Feb 14, 2025

Can we rerun CI here? Seems like the issues was solved in #48 .

@heiner
Copy link
Collaborator

heiner commented Feb 15, 2025

Kicked off a CI rerun. We can merge regardless though, this change is good.

@heiner heiner merged commit 7316e3e into NetHack-LE:main Feb 15, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants