chore: removed garbadge code, lets start with a better code - #240
chore: removed garbadge code, lets start with a better code#240itisnotsome wants to merge 3 commits into
Conversation
|
|
|
aww its blocked already :( i am sad now |
ismymiddlename
left a comment
There was a problem hiding this comment.
LGTM as discussed.
|
Okay Need Approval and Need to do a maintainer meeting to address those child like structure. over engineering, leakage of memory, proper sql builder with better inference. remove 2nd and third level abtraction, remove ambiguity of middleware which should be injected as service like other layer. and many more i cant say more shit to those code |
|
Good code comes with good payment. I guess, no one was paying the maintainers back then. |
|
Aha.. We need to raise series A for this. |
|
https://discord.gg/CTN92HwU |
|
@rashedevs you don't even have money to pay your existing interns, you are asking others to join? |
|
i will join if their is pay. But this code is utter garbage. I am just enraged. I didn't see this kind of coding since go 1.09. dont tell me about the naming sense. @rashedevs |
|
Uh I should also remove those actions and flow my bad |
|
@ismymiddlename yap, currently the internship is unpaid and offering this as lifetime internship opportunity because I run my projects as open source |
|
@ismymiddlename @rashedevs i believe there is nothing more to discuss. this pr is ready merge. And Please address the coding/writing standard in the next maintainer meeting. Awaiting for a my first contribution. |
What do you think? They run pentagon? They have meeting? Answer: No. |
The they should at least address the variable and function naming sense at least i am begging the maintainer it hurts my heart and eye |
Stop having sex with code. |
|
And I should also address one shit. In their logical check of redis. They are checking **_
_** if the redis is enable or not. I can't say more. |
|
We want more control on our cache. We have switch to on or off it, so we do certain actions if or if not cache enable..duh🙄 |
does it make sense when cache is already disabled? |
. |
|
Yea🙄 |
|
U could say there are better way to do this..maybe we'll do it |
|
I said you are checking inside the redis/kv db to check if redis is enabled or not. Still you dont see the flaw? |
Your way of coding sucks. Please learn to write better code. Please for the god sake. you are embarrassing yourself.