Skip to content

chore: removed garbadge code, lets start with a better code - #240

Open
itisnotsome wants to merge 3 commits into
NesoHQ:masterfrom
itisnotsome:master
Open

chore: removed garbadge code, lets start with a better code#240
itisnotsome wants to merge 3 commits into
NesoHQ:masterfrom
itisnotsome:master

Conversation

@itisnotsome

Copy link
Copy Markdown

Your way of coding sucks. Please learn to write better code. Please for the god sake. you are embarrassing yourself.

@cla-assistant

cla-assistant Bot commented Sep 5, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented Sep 5, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@itisnotsome

Copy link
Copy Markdown
Author

aww its blocked already :( i am sad now

@ismymiddlename ismymiddlename left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread archive-admin/.vscode/extensions.json Outdated

@ismymiddlename ismymiddlename left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed.

@itisnotsome

Copy link
Copy Markdown
Author

Okay Need Approval and Need to do a maintainer meeting to address those child like structure. over engineering, leakage of memory, proper sql builder with better inference. remove 2nd and third level abtraction, remove ambiguity of middleware which should be injected as service like other layer. and many more i cant say more shit to those code

@ismymiddlename

Copy link
Copy Markdown
Contributor

Good code comes with good payment. I guess, no one was paying the maintainers back then.

@itisnotsome

Copy link
Copy Markdown
Author

Aha.. We need to raise series A for this.

@rashedevs

Copy link
Copy Markdown
Collaborator

https://discord.gg/CTN92HwU
join us bro..

@ismymiddlename

Copy link
Copy Markdown
Contributor

@rashedevs you don't even have money to pay your existing interns, you are asking others to join?

@itisnotsome

itisnotsome commented Sep 5, 2025

Copy link
Copy Markdown
Author

i will join if their is pay. But this code is utter garbage. I am just enraged. I didn't see this kind of coding since go 1.09. dont tell me about the naming sense. @rashedevs

@itisnotsome

Copy link
Copy Markdown
Author

Uh I should also remove those actions and flow my bad

@rashedevs

Copy link
Copy Markdown
Collaborator

@ismymiddlename yap, currently the internship is unpaid and offering this as lifetime internship opportunity because I run my projects as open source

@itisnotsome

Copy link
Copy Markdown
Author

@ismymiddlename @rashedevs i believe there is nothing more to discuss. this pr is ready merge. And Please address the coding/writing standard in the next maintainer meeting. Awaiting for a my first contribution.

@ismymiddlename

Copy link
Copy Markdown
Contributor

maintainer meeting

What do you think? They run pentagon? They have meeting?

Answer: No.

@itisnotsome

Copy link
Copy Markdown
Author

No.

The they should at least address the variable and function naming sense at least i am begging the maintainer it hurts my heart and eye

@ismymiddlename

Copy link
Copy Markdown
Contributor

it hurts my heart

Stop having sex with code.

@itisnotsome

itisnotsome commented Sep 5, 2025

Copy link
Copy Markdown
Author

And I should also address one shit. In their logical check of redis. They are checking **_

### in the redis###

_** if the redis is enable or not. I can't say more.

@geomachine

Copy link
Copy Markdown
Collaborator

We want more control on our cache. We have switch to on or off it, so we do certain actions if or if not cache enable..duh🙄

@itisnotsome

Copy link
Copy Markdown
Author

We want more control on our cache. We have switch to on or off it, so we do certain actions if or if not cache enable..duh🙄

does it make sense when cache is already disabled?

@itisnotsome

Copy link
Copy Markdown
Author

They are checking in the redis

.

@geomachine

geomachine commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

Yea🙄
U don't wanna just hit redis client if it isn’t even enabled.. Also I Don't wanna execute certain methods if redis is disabled.. So yea.. It makes sense to me I guess!

@geomachine

Copy link
Copy Markdown
Collaborator

U could say there are better way to do this..maybe we'll do it

@itisnotsome

Copy link
Copy Markdown
Author

I said you are checking inside the redis/kv db to check if redis is enabled or not. Still you dont see the flaw?
and Better way not to do this altogether. if really needed. config and server should handle that not controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants