3790 - Impedir que un estado de ventas genere un documento de compras…#1888
Open
daniel89fg wants to merge 1 commit intoNeoRazorX:masterfrom
Open
3790 - Impedir que un estado de ventas genere un documento de compras…#1888daniel89fg wants to merge 1 commit intoNeoRazorX:masterfrom
daniel89fg wants to merge 1 commit intoNeoRazorX:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Este PR añade una validación en EstadoDocumento para impedir que un estado asociado a documentos de ventas pueda generar documentos de compras (y viceversa), junto con un test unitario que cubre el nuevo comportamiento.
Changes:
- Nueva validación en
EstadoDocumento::test()para bloquear combinacionesCliente→ProveedoryProveedor→Cliente. - Nuevo test unitario que verifica que no se pueden guardar estados con generación cruzada ventas/compras.
- Actualización del año de copyright en el test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Core/Model/EstadoDocumento.php | Añade la regla de validación que bloquea la generación cruzada entre ventas y compras. |
| Test/Core/Model/EstadoDocumentoTest.php | Incorpora un test que asegura que save() falla en los casos bloqueados por la nueva regla. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… y viceversa
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado: