Skip to content

Añade soporte para Range Requests y mejora de tipos MIME #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel89fg wants to merge 1 commit into
base: master
Choose a base branch
from
+69 −9
Open

Añade soporte para Range Requests y mejora de tipos MIME #1882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 69 additions & 9 deletions Core/Controller/Myfiles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ public static function isFileSafe(string $filePath): bool
{
$parts = explode('.', $filePath);
$safe = [
'7z', 'accdb', 'ai', 'avi', 'cdr', 'css', 'csv', 'doc', 'docx', 'dxf', 'dwg', 'eot', 'gif', 'gz', 'html',
'ico', 'ics', 'jfif', 'jpeg', 'jpg', 'js', 'json', 'map', 'md', 'mdb', 'mkv', 'mov', 'mp3', 'mp4', 'ndg',
'ods', 'odt', 'ogg', 'pdf', 'png', 'pptx', 'rar', 'sql', 'step', 'svg', 'ttf', 'txt', 'webm', 'webp',
'7z', 'accdb', 'ai', 'aac', 'avi', 'cdr', 'css', 'csv', 'doc', 'docx', 'dxf', 'dwg', 'eot', 'flac', 'gif', 'gz', 'html',
'ico', 'ics', 'jfif', 'jpeg', 'jpg', 'js', 'json', 'm4a', 'map', 'md', 'mdb', 'mkv', 'mov', 'mp3', 'mp4', 'ndg',
'ods', 'odt', 'ogg', 'pdf', 'png', 'pptx', 'rar', 'sql', 'step', 'svg', 'ttf', 'txt', 'wav', 'webm', 'webp',
'woff', 'woff2', 'xls', 'xlsm', 'xlsx', 'xml', 'xsig', 'zip'
];
$extension = strtolower(end($parts));
Expand All @@ -90,20 +90,58 @@ public function run(): void
return;
}

header('Content-Type: ' . $this->getMime($this->filePath));
$mimeType = $this->getMime($this->filePath);
$fileSize = filesize($this->filePath);

// Permite acceso CORS para que Safari pueda cargar recursos
header('Access-Control-Allow-Origin: *');

// Manejo de Range Requests para Safari (crucial para audio)
$start = 0;
$end = $fileSize - 1;

if (isset($_SERVER['HTTP_RANGE']) && preg_match('/bytes=(\d+)-(\d*)/', $_SERVER['HTTP_RANGE'], $matches)) {
$start = intval($matches[1]);
$end = $matches[2] !== '' ? intval($matches[2]) : $end;

header('HTTP/1.1 206 Partial Content');
header('Content-Range: bytes ' . $start . '-' . $end . '/' . $fileSize);
header('Content-Length: ' . ($end - $start + 1));
} else {
header('HTTP/1.1 200 OK');
header('Content-Length: ' . $fileSize);
}

header('Content-Type: ' . $mimeType);
header('Accept-Ranges: bytes');
header('Cache-Control: public, max-age=31536000, immutable');

// Para archivos de audio, nunca descargar - siempre reproducir inline
if (strpos($mimeType, 'audio') === 0) {
header('Content-Disposition: inline; filename="' . basename($this->filePath) . '"');
} else {
// force to download svg, xml and html files to prevent XSS attacks
if ($this->shouldForceDownload($this->filePath)) {
header('Content-Disposition: attachment; filename="' . basename($this->filePath) . '"');
}
}

// disable the buffer if enabled
if (ob_get_contents()) {
ob_end_flush();
}

// force to download svg, xml and html files to prevent XSS attacks
if ($this->shouldForceDownload($this->filePath)) {
header('Content-Disposition: attachment; filename="' . basename($this->filePath) . '"');
// Enviar el archivo
if (isset($_SERVER['HTTP_RANGE'])) {
// Enviar solo el rango solicitado
$file = fopen($this->filePath, 'rb');
fseek($file, $start);
echo fread($file, $end - $start + 1);
fclose($file);
} else {
// Enviar el archivo completo
readfile($this->filePath);
}

readfile($this->filePath);
}

private function getMime(string $filePath): string
Expand All @@ -120,6 +158,28 @@ private function getMime(string $filePath): string
case 'xml':
case 'xsig':
return 'text/xml';

// Formatos de audio - asegurar tipos MIME correctos
case 'm4a':
return 'audio/mp4';

case 'mp3':
return 'audio/mpeg';

case 'wav':
return 'audio/wav';

case 'ogg':
return 'audio/ogg';

case 'webm':
return 'audio/webm';

case 'aac':
return 'audio/aac';

case 'flac':
return 'audio/flac';
}

return mime_content_type($filePath);
Expand Down
Loading