Handle improper lists in RedactorEncoder #149
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Currently,
RedactorEncoder
can't handle an improper list and would crash a formatter:This PR attempts to fix it. There are probably multiple ways this can be addressed, but I went with
inspect
ing the list after all individual elements were encoded. This way it'll be visible that something isn't right and no data will go unredacted.Oh, and my personal real world example where the redactor was crashing is when I tried to log
Plug.Conn.resp_body
, which is of iodata type and is often an improper list.Let me know what you think!