feat(settings): Company Profile settings page, logo upload, validation (issue #418)#462
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #418
Adds a Company Profile settings page so companies can manage their public profile and branding (logo) inside the app instead of contacting support.
What I changed
Added: Company profile UI + test
frontend/src/pages/Settings/CompanyProfile/CompanyProfile.tsx
frontend/src/pages/Settings/CompanyProfile/CompanyProfile.test.tsx
Updated:
Integrated tab: frontend/src/pages/Settings/Settings.tsx
Navbar now shows saved company logo:
Files touched
Added: frontend/src/pages/Settings/CompanyProfile/CompanyProfile.tsx
Added: frontend/src/pages/Settings/CompanyProfile/CompanyProfile.test.tsx
Modified: frontend/src/pages/Settings/Settings.tsx
Modified: frontend/src/components/Navbar/Navbar.tsx
Acceptance criteria checklist
All fields editable and saved per section: implemented and persisted to localStorage.
Logo upload, crop, and preview: implemented client-side, preview before save.
Validation errors show inline: implemented per-field with messages.
Unsaved changes indicator per section: implemented (dot indicator in section header).
Saved logo appears in Navbar: implemented (reads navin-company-logo on route change).
How to test locally
Start dev server:
Open Settings → select the new "Company Profile" tab (company-only tab).
Try editing sections, observe unsaved dot, click per-section Save.
Upload an image via the Branding section and Save — logo should appear in the Navbar.