Skip to content

fix(catalyst): variable-length arrays #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NathanWalker
Copy link
Contributor

Fixes the mac catalyst build when using Xcode 16.4. The following errors are now resolved:

NativeScript/runtime/Timers.cpp:166:27: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
  166 |         Local<Value> argv[argc];
NativeScript/runtime/FFICall.h:46:62: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
   46 |             this->StackSize = malloc_good_size(sizeof(void* [argsCount]));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant