Skip to content

Conversation

@farfromrefug
Copy link
Contributor

@farfromrefug farfromrefug commented Oct 25, 2025

This PR add many things which improve typings generation:

  • improved PR Updates to tackle Kotlin compatibility issues (#84) #85, fixing bugs and adding more edge cases
  • handle kotlin parameters without return paramter names with forbidden chars
  • ensure replaceGenericsInText does not remove > chars far already any types
  • better detection of open/close namespace to prevent unclosed namespaces
  • some inner namespaces where not correctly filled/exported
  • kotlin Companion is now a namespace making static functions being reported correctly
  • add eslint rules at the top to prevent vscode errors
  • constant values real value is now exported as jsdoc. Using direct values was failing in some cases and vscode was reporting errors

Some commits are listed here while already merged

farfromrefug and others added 25 commits March 3, 2022 21:05
# Conflicts:
#	dts-generator/gradle/wrapper/gradle-wrapper.properties
#	dts-generator/src/main/java/com/telerik/dts/DtsApi.java
# Conflicts:
#	dts-generator/src/main/java/com/telerik/dts/DtsApi.java
# Conflicts:
#	dts-generator/src/main/java/com/telerik/dts/DtsApi.java
* handle kotlin parameters without return paramter names with forbidden chars
* ensure replaceGenericsInText does not remove > chars far already any types
* better detection of open/close namespace to prevent unclosed namespaces
* some inner namespaces where not correctly filled/exported
@dangrima90
Copy link

dangrima90 commented Oct 26, 2025

@farfromrefug I tested the PR and from my end it's looking good. It seems that you encountered more edge cases than me!

Some points from my end:

  • The constant values fix you did was something I did notice and from my tests but in my case it looked like when placing the .d.ts file in a nativescript project those VS Code warnings went away. Still I think your solution makes more sense as TS was complaining about the constant values.
  • I did see the change from module to namespace and did a bit of research just to make sure it won't affect anything. From what I checked the typings generated here should export namespace and not module as these typings are not imported (therefore they aren't a module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants