Skip to content

Release Notes for Desktop #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 28, 2025
Merged

Release Notes for Desktop #98

merged 7 commits into from
Mar 28, 2025

Conversation

PeteBishwhip
Copy link
Member

@PeteBishwhip PeteBishwhip commented Mar 27, 2025

Follow on from #94 where a merge had somehow pulled in a bunch of commits that were already present. It made the PR messy so opened it up again.

Comments taken on board. I've reduced the PR links down to Issue Numbers only as requested:

image

Side Note: Looks like we have a bug in the right hand nav with HTML encoding. Happy to look at that.

@PeteBishwhip PeteBishwhip requested review from simonhamp and a team March 27, 2025 10:34
@PeteBishwhip
Copy link
Member Author

PeteBishwhip commented Mar 27, 2025

I've fixed the bug on the right hand side nav in this PR.

Essentially, the parser provides the title html entity encoded - I pass it through decode before it reaches the view.

image

@simonhamp
Copy link
Member

I made this hacky change yesterday just as you were closing the other PR

I found those 'What's changed' and 'New contributors' headings a bit odd, both visually jarring in the sidebar, but also they're not unique anchors on the page, so you can't really jump to them reliably.

I felt it made more sense just to demote them so they were no longer a thing

@PeteBishwhip
Copy link
Member Author

@simonhamp Your wish is my command ✨
image

@simonhamp
Copy link
Member

🥹

@simonhamp simonhamp merged commit 9d7e511 into main Mar 28, 2025
1 check passed
@PeteBishwhip PeteBishwhip deleted the feature/release-notes-2 branch March 28, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants