Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsors in sidebar #51

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Sponsors in sidebar #51

merged 3 commits into from
Sep 19, 2024

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Sep 19, 2024

Refers to NativePHP/laravel#364

Okay, I made a lot of changes:

  • Optimized logo sizes
  • Components for logo categories (easier to add one)
  • Component for each SVG
  • Kept the same proportions on the welcome page
  • Fixed Sevalla dark mode
  • And of course, logos on the sidebar

My future recommandations

  • It would be perfect with Beyond Code SVG logo.
  • Maybe take some time for the welcome page: example app or code

@SRWieZ
Copy link
Member Author

SRWieZ commented Sep 19, 2024

HomePage: Before => After (you can see I fixed some logos so they don't have blank gutter)

Capture d’écran 2024-09-19 à 01 55 50 Capture d’écran 2024-09-19 à 01 55 53

Introduction: Before => After

Capture d’écran 2024-09-19 à 01 56 00 Capture d’écran 2024-09-19 à 01 56 03

Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@simonhamp
Copy link
Member

  • It would be perfect with Beyond Code SVG logo.

Agreed. Working on it

  • Maybe take some time for the welcome page: example app or code

Yep, I think that will be useful. It will come in time

@simonhamp simonhamp merged commit 588ba73 into NativePHP:main Sep 19, 2024
@SRWieZ
Copy link
Member Author

SRWieZ commented Sep 19, 2024

  • It would be perfect with Beyond Code SVG logo.

Agreed. Working on it

When done, you can remove the sameHeight props from sponsors-featured.blade.php. BeyondCode as SVG will be easier to get to the same height without the padding I added to Laradir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants