fix(php): resolve path import error and ensure ESM compatibility #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the PHP binary extraction errors reported in #336 by:
Changes:
✅ ESM Path Fixes
resolve
anddirname
frompath
import.meta.dirname
withfileURLToPath
(ESM standard)join()
operations that could receive undefined values✅ Error Prevention
NATIVEPHP_PHP_BINARY_PATH
NATIVEPHP_PHP_BINARY_VERSION
✅ Tested Environments
Impact:
Verification Steps
resources/php/php[.exe]
Closes #336