Adjust window dimensions based on the resizable property.
#215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the logic to set window width and height to ignore stored window state when `resizable` is false. This ensures consistent behavior for fixed-size windows regardless of previous state data.
|
Hey @gwleuverink, are you still missing something in your eyes? |
|
I just sent you a dm before reading this |
gwleuverink
approved these changes
May 9, 2025
There was a problem hiding this comment.
Thanks! I ran it and it works 🙏 The terniary was hard to parse, but that was already the case before the change.
I wonder if we can clean this up for readability while we're touching this. Maybe pull it into a function & break the conditionals up?
It was already like this, so it's approved 👍 just recognising a possible refactor opportunity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the logic to set window width and height to ignore stored window state when
resizableis false. This ensures consistent behavior for fixed-size windows regardless of previous state data.