Skip to content

Add CLAUDE.md to align @claude PR reviews with automated review rules#140

Open
matthallett1 wants to merge 5 commits intomainfrom
claude/document-repo-overview-GeGDa
Open

Add CLAUDE.md to align @claude PR reviews with automated review rules#140
matthallett1 wants to merge 5 commits intomainfrom
claude/document-repo-overview-GeGDa

Conversation

@matthallett1
Copy link
Copy Markdown
Collaborator

The Claude Code GitHub App responds to @claude mentions on PRs but had
no repo-specific context. This file teaches it the same 11-rule review
checklist that ob1-review.yml enforces, so manual @claude reviews and
automated CI checks apply the same standards.

https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79

The Claude Code GitHub App responds to @claude mentions on PRs but had
no repo-specific context. This file teaches it the same 11-rule review
checklist that ob1-review.yml enforces, so manual @claude reviews and
automated CI checks apply the same standards.

https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 31, 2026
Test contribution with 3 intentional issues for @claude to catch:
- DELETE FROM without WHERE clause (Rule 5: SQL safety)
- Missing "expected outcome" section (Rule 9: README completeness)
- "difficulty": "easy" instead of beginner/intermediate/advanced (Rule 3: Metadata)

Do not merge — delete after testing.

https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79
@github-actions github-actions bot added the recipe Contribution: step-by-step recipe label Mar 31, 2026
Replaces the auto-pass stub in ob1-review.yml with a real Claude API
call (Haiku) that reviews contribution READMEs for clarity, missing
steps, and correctness. Gracefully skips if ANTHROPIC_API_KEY secret
is not configured.

Also updates CLAUDE.md and CONTRIBUTING.md to reflect that Rule 11
is now live.

Requires: Add ANTHROPIC_API_KEY as a repository secret in GitHub
Settings → Secrets → Actions.

https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79
@matthallett1
Copy link
Copy Markdown
Collaborator Author

@claude review this.

claude added 2 commits March 31, 2026 01:48
The multi-line prompt string with embedded $() and braces was causing
YAML parsing failures on line 451. Refactored to write the prompt to
temp files and use jq --rawfile for safe JSON escaping, avoiding any
YAML interpretation issues.

https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation recipe Contribution: step-by-step recipe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants