Add CLAUDE.md to align @claude PR reviews with automated review rules#140
Open
matthallett1 wants to merge 5 commits intomainfrom
Open
Add CLAUDE.md to align @claude PR reviews with automated review rules#140matthallett1 wants to merge 5 commits intomainfrom
matthallett1 wants to merge 5 commits intomainfrom
Conversation
The Claude Code GitHub App responds to @claude mentions on PRs but had no repo-specific context. This file teaches it the same 11-rule review checklist that ob1-review.yml enforces, so manual @claude reviews and automated CI checks apply the same standards. https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79
Test contribution with 3 intentional issues for @claude to catch: - DELETE FROM without WHERE clause (Rule 5: SQL safety) - Missing "expected outcome" section (Rule 9: README completeness) - "difficulty": "easy" instead of beginner/intermediate/advanced (Rule 3: Metadata) Do not merge — delete after testing. https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79
Replaces the auto-pass stub in ob1-review.yml with a real Claude API call (Haiku) that reviews contribution READMEs for clarity, missing steps, and correctness. Gracefully skips if ANTHROPIC_API_KEY secret is not configured. Also updates CLAUDE.md and CONTRIBUTING.md to reflect that Rule 11 is now live. Requires: Add ANTHROPIC_API_KEY as a repository secret in GitHub Settings → Secrets → Actions. https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79
Collaborator
Author
|
@claude review this. |
The multi-line prompt string with embedded $() and braces was causing YAML parsing failures on line 451. Refactored to write the prompt to temp files and use jq --rawfile for safe JSON escaping, avoiding any YAML interpretation issues. https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Claude Code GitHub App responds to @claude mentions on PRs but had
no repo-specific context. This file teaches it the same 11-rule review
checklist that ob1-review.yml enforces, so manual @claude reviews and
automated CI checks apply the same standards.
https://claude.ai/code/session_01XYNmBjSUAeV6VuvWyp1Y79