Skip to content

Exclusion refactor - #265

Merged
ppinchuk merged 59 commits into
mainfrom
pp/excl_refactor
Mar 5, 2026
Merged

ppinchuk merged 59 commits into
mainfrom
pp/excl_refactor

Conversation

@ppinchuk

@ppinchuk ppinchuk commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Refactor setbacks + turbine flicker to more general "exclusions" module to make room for new types of exclusions and add support for max height and blade clearance exclusions.

@ppinchuk ppinchuk self-assigned this Mar 4, 2026
@ppinchuk ppinchuk added refactor Code refactor or update p-high Priority: high new computation Update that adds a new computation method topic-setbacks Issues/pull requests related to setbacks calculations labels Mar 4, 2026
@codecov-commenter

codecov-commenter commented Mar 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.02899% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.73%. Comparing base (27b1eac) to head (09bed7e).
⚠️ Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
reVX/exclusions/max_height/regulations.py 67.50% 10 Missing and 3 partials ⚠️
reVX/exclusions/turbine_flicker/_cli.py 42.10% 11 Missing ⚠️
reVX/exclusions/blade_clearance/_cli.py 52.94% 8 Missing ⚠️
reVX/exclusions/max_height/_cli.py 52.94% 8 Missing ⚠️
reVX/exclusions/blade_clearance/blade_clearance.py 82.85% 5 Missing and 1 partial ⚠️
reVX/exclusions/blade_clearance/regulations.py 85.71% 4 Missing and 2 partials ⚠️
reVX/exclusions/max_height/max_height.py 83.78% 5 Missing and 1 partial ⚠️
reVX/exclusions/base.py 98.01% 0 Missing and 2 partials ⚠️
reVX/exclusions/setbacks/_cli.py 80.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   70.40%   70.73%   +0.32%     
==========================================
  Files          76       82       +6     
  Lines       10510    10570      +60     
  Branches     1217     1226       +9     
==========================================
+ Hits         7400     7477      +77     
+ Misses       2630     2605      -25     
- Partials      480      488       +8     
Flag Coverage Δ
unittests 70.73% <82.02%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
reVX/cli.py 72.25% <100.00%> (ø)
reVX/exclusions/_cli.py 100.00% <100.00%> (ø)
reVX/exclusions/regulations.py 100.00% <ø> (ø)
reVX/exclusions/setbacks/base.py 93.98% <100.00%> (ø)
reVX/exclusions/setbacks/functions.py 100.00% <ø> (ø)
reVX/exclusions/setbacks/regulations.py 91.76% <100.00%> (ø)
reVX/exclusions/setbacks/setbacks.py 71.42% <100.00%> (ø)
reVX/exclusions/setbacks/setbacks_converter.py 18.96% <ø> (ø)
reVX/exclusions/turbine_flicker/regulations.py 45.83% <100.00%> (ø)
reVX/exclusions/turbine_flicker/turbine_flicker.py 17.49% <100.00%> (ø)
... and 9 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk
ppinchuk merged commit 8accff3 into main Mar 5, 2026
11 checks passed
@ppinchuk
ppinchuk deleted the pp/excl_refactor branch March 5, 2026 00:04
github-actions Bot pushed a commit that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new computation Update that adds a new computation method p-high Priority: high refactor Code refactor or update topic-setbacks Issues/pull requests related to setbacks calculations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants