Skip to content

Allow GPKG input for setbacks calcualtion - #263

Merged
ppinchuk merged 20 commits into
mainfrom
pp/setbacks_shapes
Dec 11, 2025
Merged

ppinchuk merged 20 commits into
mainfrom
pp/setbacks_shapes

Conversation

@ppinchuk

Copy link
Copy Markdown
Collaborator

Allow users to input GPKG with jurisdiction shapes so that a cnty fips layer is not required (and can now do sub-county resolution)

@ppinchuk ppinchuk self-assigned this Dec 11, 2025
@ppinchuk ppinchuk added refactor Code refactor or update enhancement Update to logic or general code improvements p-high Priority: high labels Dec 11, 2025
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.03448% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.73%. Comparing base (50b0092) to head (3d0108c).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
reVX/utilities/exclusions.py 75.00% 7 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   74.80%   72.73%   -2.08%     
==========================================
  Files          76       76              
  Lines       10468    10510      +42     
  Branches     1211     1217       +6     
==========================================
- Hits         7831     7644     -187     
- Misses       2146     2372     +226     
- Partials      491      494       +3     
Flag Coverage Δ
unittests 72.73% <81.03%> (-2.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
reVX/setbacks/base.py 95.77% <100.00%> (ø)
reVX/setbacks/regulations.py 91.76% <ø> (ø)
reVX/setbacks/setbacks_cli.py 60.68% <ø> (-22.23%) ⬇️
reVX/turbine_flicker/turbine_flicker.py 88.59% <100.00%> (ø)
reVX/utilities/reeds_cols.py 72.60% <ø> (ø)
reVX/utilities/regulations.py 100.00% <100.00%> (ø)
reVX/utilities/exclusions.py 83.84% <75.00%> (-3.41%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk

Copy link
Copy Markdown
Collaborator Author

Confirmed that this works on HPC with COMPASS data.
Before:

image

After:
image

@ppinchuk ppinchuk linked an issue Dec 11, 2025 that may be closed by this pull request
@ppinchuk
ppinchuk merged commit d3252e0 into main Dec 11, 2025
13 checks passed
@ppinchuk
ppinchuk deleted the pp/setbacks_shapes branch December 11, 2025 18:48
github-actions Bot pushed a commit that referenced this pull request Dec 11, 2025
Allow GPKG input for setbacks calcualtion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements p-high Priority: high refactor Code refactor or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setbacks from shapes

2 participants