Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the LFP material properties for both
DsandEeqto match new values from ICI measurements. Note that new diffusivity values were 3-4 orders of magnitude lower than previous values, which caused the model only to achieve a small fraction (~1/10) of the capacity, even when simulated at low rates (C/20).The new diffusivities were scaled until simulations at C/10 could run for approximately 10 hours, and radial solid-phase lithium concentrations were roughly uniform. This required a scaling of 1,000-10,000. The diffusivity value included in the new LFP material file is also a constant because the functional form from ICI varied at both ends of lithiation (near
xs=0andxs=1) by 3-4 orders of magnitude and created some unphysical results.Type of change
Key checklist:
$ nox -s linter [-- format]$ nox -s codespell [-- write]$ nox -s tests$ nox -s badgesFurther checks:
$ nox -s docs.