Fix issue when headers are parsed and a NaN is encountered#23
Merged
Fix issue when headers are parsed and a NaN is encountered#23
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 30.09% 30.07% -0.02%
==========================================
Files 40 40
Lines 1738 1739 +1
==========================================
Hits 523 523
- Misses 1215 1216 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For excel files with NaN in a given row the
find_headersfunction would break because even when the row is converted to astr, the NaN remains afloat. This has now been fixed by replacing NaN with empty strings during header parsing.This PR also includes some minor changes to the error codes that ruff checks for.
Type of change
Key checklist:
$ nox -s linter [-- format]$ nox -s codespell [-- write]$ nox -s tests$ nox -s badgesFurther checks:
$ nox -s docs.