-
Notifications
You must be signed in to change notification settings - Fork 66
Clean EnSite payload builder #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the EnSite payload builder for translating UI inputs to EnLitePy format. The changes simplify the schema by enforcing single-purpose keys and improve deterministic behavior for EMS capacity derivation.
Key changes:
- Simplified UI schema with single-purpose field enforcement (pChgMax_kW for vehicles, pChgCap_kW for EMS)
- Deterministic EMS capacity auto-derivation from charger configurations when no override provided
- Added optional debug payload echo feature for troubleshooting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| load_builder/views.py | Major refactoring of payload builder with simplified validation, deterministic capacity derivation, and debug features |
| CHANGELOG.md | Documentation of changes including schema version bump and new debug functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
What is the current behavior?
(You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information: