-
Notifications
You must be signed in to change notification settings - Fork 66
v3.14.0: Add CST and HighTempThermalStorage, Update Defaults #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Needed for NSRDB API call within SAM SSC for CST
…o add-cst-reopt
…nary (TBD if it needs to be)
…o add-cst-reopt
Co-authored-by: Copilot <[email protected]>
Add CST and HighTempThermalStorage, and Update Defaults
|
@adfarth These are our two PRs, and I think you can just look for high-level red flags. |
|
@Bill-Becker just checking, we no longer need to manually update the REopt Julia version in the reoptjl/api "meta" dictionary, as stated here, right? https://github.com/NREL/REopt.jl/wiki/Steps-to-register-a-new-version-of-the-REopt-package |
|
@Bill-Becker have the new CST endpoints been tested with a staged web tool page yet? |
adfarth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending confirmation that the endpoints have been tested, looks good at a high level!
No new endpoints for CST. |
|
Tested deploying develop branch to staging with an existing database, and ran a few runs there. Things look good, so merging in. I'll wait to deploy until we have the User Manual ready to go and we sync with Erika for the UI deploy. |
PRs: