-
Notifications
You must be signed in to change notification settings - Fork 38
[v3.11] Fervo_Project_Cape-5: Multi-Year Construction & Reservoir Engineering updates; SAM-EM Payback Period; SAM-EM ITC; User-Provided Reservoir Profile updates; SAM-EM MCY Levelized Metrics update #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
softwareengineerprogrammer
wants to merge
498
commits into
NatLabRockies:main
Choose a base branch
from
softwareengineerprogrammer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[v3.11] Fervo_Project_Cape-5: Multi-Year Construction & Reservoir Engineering updates; SAM-EM Payback Period; SAM-EM ITC; User-Provided Reservoir Profile updates; SAM-EM MCY Levelized Metrics update #457
softwareengineerprogrammer
wants to merge
498
commits into
NatLabRockies:main
from
softwareengineerprogrammer:main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ominally align with the fact that the fracture is at least slightly wider than spacing
…t includes discussion of limitations (https://samrepo.nrelcloud.org/help/mtf_payback.html)
…e-mcy-and-res-eng-updates-2
…able for sidebar.js (WIP - sidebar interactivity works now but styling is broken)
…r to fix generated schema (parsers do not like +/-Infinity)
…effect). add link from FPC4 doc to FPC5 doc
…ly lower) IRR than FPC5
…ersion: v3.11.12)
…wn 1 (now a subsection of Variants)
…mments. fix existing sensitivity analysis section links
brtietz
approved these changes
Jan 30, 2026
Collaborator
brtietz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on review in #444
Would recommend another review for reservoir engineering components prior to merging.
hpauling-nrel
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or improvement (as opposed to bug/problem)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fervo_Project_Cape-5example and variants including 100 MWFervo_Project_Cape-6Reservoir Output Profileparameter #453: [v3.11.8] User-Provided Reservoir Output File Fix, Reservoir Output Profile Parameter, and Redrilling Support softwareengineerprogrammer/GEOPHIRES#129Links (PR Reviewers: Start by looking at these)
Fervo_Project_Cape-5(500 MW/Phases I & II):Fervo_Project_Cape-6(100 MW/Phase I)Testing & Verification
Fervo_Project_Cape-5andFervo_Project_Cape-6standard example test coverageFervoProjectCape5TestCaseFervoProjectCape5GraphsTestCasetest_post_processed_levelized_metricsexample5btest_produced_temperature_json_outputtest_number_of_injection_wells_per_production_wellexample_SAM-single-owner-PPA*:Investment Tax Creditoutput addedProject Payback Periodfixedexample5.outdue to reservoir output profile file reading fixTODO
.txt).txt)Release (Change Checklist)
Before merging
After merging
git push origin refs/tags/vM.m.PLower Priority
Done
Fervo_Project_Cape-6: softwareengineerprogrammer@866b4c8, softwareengineerprogrammer@d7bcda0, 9d3dd02example5bto web interface:Add a CHANGELOG entry for 3.11.4: 1ca1705Originally self-reviewed in softwareengineerprogrammer#117