feat: add ssl config to json configuration#179
Merged
Conversation
MartinFillon
requested changes
Jun 24, 2026
MartinFillon
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves issue #156 by allowing users to define their SSL configuration directly within the
nanoforge.config.jsonfile, removing the strict need to pass--certand--keyas CLI arguments every time.Key changes:
SslConfigblock (enable,cert,key) toconfig.type.tsandconfig-defaults.ts.resolveSSLmethod instart.action.tsto read from the JSON config if the CLI arguments are missing.CLIErrorhandling with suggestions if SSL is requested but certificates/keys are missing from both the CLI args and the JSON config.Closes #156
How do you test this PR?
pnpm run build).nanoforge.config.json: