feat(auth): add login and signup pages with validation#8
Closed
Yaswanth1832K wants to merge 11 commits into
Closed
feat(auth): add login and signup pages with validation#8Yaswanth1832K wants to merge 11 commits into
Yaswanth1832K wants to merge 11 commits into
Conversation
Yaswanth1832K
requested review from
Adwaith2207,
Nandgopal-R,
adar-ssh and
hemanth45-gudi
and removed request for
Adwaith2207 and
hemanth45-gudi
adar-ssh
requested changes
Feb 2, 2026
| @@ -0,0 +1,168 @@ | |||
| body { | |||
| margin: 0; | |||
Collaborator
There was a problem hiding this comment.
Why does the auth page have a seperate css . Is it a required file?
Otherwise add every styling as a tailwindcss class
| /> | ||
| {password.length > 0 && ( | ||
| <span className="eye" onClick={() => setShowPassword(!showPassword)}> | ||
| {showPassword ? "✖" : "👁️"} |
Collaborator
There was a problem hiding this comment.
Make use of lucide-react icons only , do not use emojis
| return; | ||
| } | ||
|
|
||
| if (!email.includes("@")) { |
Collaborator
|
Do not edit the styles.css file. Revert the file to the previous version |
adar-ssh
reviewed
Feb 3, 2026
Collaborator
There was a problem hiding this comment.
I recommend sticking with OKCLH over HSL .It has better color accuracy compared to HSL
Yaswanth1832K
force-pushed
the
feat/auth-pages
branch
from
017d4c6 to
ee66bc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.