Skip to content

Fix batch exporter shutdown race condition #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nancy-Chauhan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix batch exporter shutdown race condition #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/acme_sdk/utils/batching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,13 @@ def shutdown(self, timeout: float | None = None) -> None:
if timeout is None:
timeout = self._flush_interval * 3
self._thread.join(timeout=timeout)


def _ensure_flush_on_shutdown(processor: BatchProcessor) -> None:
"""Ensure final flush happens before interpreter exit.

This is registered as an atexit handler and ensures that the
background flush thread completes before the interpreter exits.
"""
if not processor._shutdown:
processor.shutdown(timeout=processor._flush_interval * 3)