♻️ Refactor: 친구 목록 조회시 성능 개선

<body> N+1 문제 방지 및 성능 개선을 위한 friend 정보 fetch join 처리 - 관련 : #384
Namo-log · Oct 23, 2024 · 2d0e16f · 2d0e16f
1 parent 557c4c5
commit 2d0e16f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.../src/main/java/com/namo/spring/db/mysql/domains/user/repository/FriendshipRepository.java b/.../src/main/java/com/namo/spring/db/mysql/domains/user/repository/FriendshipRepository.java
@@ -9,6 +9,7 @@
 import com.namo.spring.db.mysql.domains.user.dto.FriendBirthdayQuery;
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
 
 import com.namo.spring.db.mysql.domains.user.entity.Friendship;
 import com.namo.spring.db.mysql.domains.user.type.FriendshipStatus;
@@ -51,5 +52,8 @@ List<FriendBirthdayQuery> findBirthdayVisibleFriendIdsByPeriod(
 
     Optional<Friendship> findByMemberIdAndFriendIdAndStatus(Long memberId, Long friendId, FriendshipStatus status);
 
-    Page<Friendship> findAllByMemberIdAndStatus(Long memberId, FriendshipStatus status, Pageable pageable);
+    @Query("SELECT f FROM Friendship f "
+            + "JOIN FETCH f.friend "
+            + "WHERE f.member.id = :memberId AND f.status = :status")
+    Page<Friendship> findAllByMemberIdAndStatusFetchJoin(@Param("memberId") Long memberId, @Param("status") FriendshipStatus status, Pageable pageable);
 }
diff --git a/...sql-v2/src/main/java/com/namo/spring/db/mysql/domains/user/service/FriendshipService.java b/...sql-v2/src/main/java/com/namo/spring/db/mysql/domains/user/service/FriendshipService.java
@@ -44,7 +44,7 @@ public Page<Friendship> readAllReceivedFriendshipByStatus(Long memberId, Friends
      * memberId(나)에서 시작한 친구 관계로 탐색
      */
     public Page<Friendship> readAllRequestFriendshipByStatus(Long memberId, FriendshipStatus status, Pageable pageable) {
-        return friendshipRepository.findAllByMemberIdAndStatus(memberId, status, pageable);
+        return friendshipRepository.findAllByMemberIdAndStatusFetchJoin(memberId, status, pageable);
     }
 
     public Optional<Friendship> readFriendshipByStatus(Long friendshipId, FriendshipStatus status){