Add automatic demotion of OpenGL version; fix MacOS failing tests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new method has been added to the initialization of the program which iterates through the available OpenGL versions, starting from 4.3, and works backward until reaching the maximum version of OpenGL supported on the system. This is done by creating a GLFW version with a specified version. If this fails, then the version must not be supported.
Some changes have been made in order to stop tests from failing in MacOS: -Placed forward compatibility before OpenGL version demotion function -Added version specifier to test OpenGL shader, as MacOS drivers seem to require it. -Added preprocessor directive to not include glGetnUniformfv if running in MacOS, as this seems to not be supported by the driver.
fayalalebrun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added automatic demotion of the OpenGL version. I don't like this, and think we should instead just define a minimum version (4.1, probably) and if we need functionality of a newer version use OpenGL extensions. See description below:
A new method has been added to the initialization of the program which
iterates through the available OpenGL versions, starting from 4.3, and
works backward until reaching the maximum version of OpenGL supported
on the system.
This is done by creating a GLFW version with a specified version. If
this fails, then the version must not be supported.
Resolves #27.
Resolves #35.