Fix storage bar rendering for image-background themes - #352
Merged
Conversation
Use progressbar_background instead of background for the storage bar track, since background may be a wallpaper texture without a usable colour value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom themes that set
backgroundto a wallpaper image had broken eMMC and microSD indicators in the top bar. The storage bars drew their inner track usingGetColour(ThemeEntryID_BACKGROUND), but whenbackgroundis an image path sphaira loads it as a texture, not a color.GetColour()then returns an invalid/transparent value, so the bar track disappears.Themes with a solid color background (like the default theme) were unaffected.
This change uses
ThemeEntryID_PROGRESSBAR_BACKGROUNDfor the storage bar track instead, which is always a color and is already defined in most themes.Changes
menu_base.cpp: fix top-bar System/microSD storage indicatorsgc_menu.cpp: fix the same storage bar drawing in the GC menu