Skip to content

DRY up the EDM connectors#2354

Merged
alexrichey merged 1 commit into
mainfrom
ar-refactor-edm-connectors
May 11, 2026
Merged

DRY up the EDM connectors#2354
alexrichey merged 1 commit into
mainfrom
ar-refactor-edm-connectors

Conversation

@alexrichey
Copy link
Copy Markdown
Contributor

@alexrichey alexrichey commented May 6, 2026

I'm needed to add a connector for plan for our Dagster work, but the existing EDM Connectors are in a less than ideal shape. This refactors them, and adds a plan connector, which we'll invoke when plan recipes in Dagster.

We've got very, very comprehensive tests around this, so I feel confident about functionality. But I'm going to run a nightly_qa off it just to be a little more confident.

@alexrichey alexrichey force-pushed the ar-refactor-edm-connectors branch 5 times, most recently from 975cb0c to a20adec Compare May 7, 2026 20:18
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 89.44724% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.76%. Comparing base (a142742) to head (38f2819).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
dcpy/connectors/edm/connectors.py 89.89% 13 Missing and 6 partials ⚠️
dcpy/models/connectors/edm/publishing.py 77.77% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
dcpy/lifecycle/connector_registry.py 100.00% <100.00%> (ø)
dcpy/models/connectors/edm/publishing.py 93.33% <77.77%> (-3.89%) ⬇️
dcpy/connectors/edm/connectors.py 89.89% <89.89%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexrichey alexrichey force-pushed the ar-refactor-edm-connectors branch 2 times, most recently from 6bc876f to 83c263a Compare May 7, 2026 20:41
@alexrichey alexrichey force-pushed the ar-refactor-edm-connectors branch from 83c263a to 38f2819 Compare May 11, 2026 15:02
@alexrichey alexrichey requested a review from damonmcc May 11, 2026 15:15
@alexrichey alexrichey merged commit a736b94 into main May 11, 2026
42 of 62 checks passed
@alexrichey alexrichey deleted the ar-refactor-edm-connectors branch May 11, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant