Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save raw volumes python terminal #1578

Merged

Conversation

franz96521
Copy link
Contributor

added the function save_raw_volumes for the python terminal as expressed here
#1202

@franz96521 franz96521 changed the title save raw volumes pyhon terminal save raw volumes python terminal Oct 26, 2024
@Tom94
Copy link
Collaborator

Tom94 commented Oct 26, 2024

Hi, thanks for the PR, but since the function you added is duplicated code from the GUI routine, the function should really take a bunch of the things it currently computes locally as input (like filename, resolution, aabb, view direction, and whether or not to flip the y and z axes) and then be called from the GUI code as well. You can take a look at Testbed::compute_and_save_png_slices for an analogous example that has already been generalized this way.

@Tom94 Tom94 merged commit 6656214 into NVlabs:master Nov 7, 2024
13 checks passed
@Tom94
Copy link
Collaborator

Tom94 commented Nov 7, 2024

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants