Repository navigation
fix(trtllm): forward served model name to native workers - #495
Merged
ishandhanani merged 2 commits intoSep 22, 2026
Merged
ishandhanani merged 2 commits into
ishandhanani merged 2 commits into
Conversation
将显式配置的服务模型名传给原生 TRT-LLM worker,确保服务器与 benchmark/eval 客户端使用一致的 API 模型名。 Signed-off-by: adibarra <93070681+adibarra@users.noreply.github.com>
按现有测试风格只验证模型名参数的传递和省略,去掉无关命令细节及重复路径断言,并简化示例注释。 Signed-off-by: adibarra <93070681+adibarra@users.noreply.github.com>
adibarra
marked this pull request as ready for review
September 22, 2026 20:08
adibarra
requested review from
alec-flowers,
csahithi,
hjjq,
ishandhanani,
kedarpotdar-nv,
kyleliang-nv,
nlevin-ui and
qiching
as code owners
September 22, 2026 20:08
ishandhanani
added a commit
to SemiAnalysisAI/srt-slurm
that referenced
this pull request
Sep 23, 2026
Signed-off-by: Ishan Dhanani <idhanani@nvidia.com> NVIDIA#431 landed on main as the squash 2917b06, so the AMD runtime commit on this branch is now also in main; the merge keeps one copy and the diff against main is only the MoRI-IO layer. Also picks up the TRT-LLM served-model-name forward (NVIDIA#495) and its VRNVL72 NUMA default (NVIDIA#493). docs/schema-reference.md was the only conflict and is regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit
engine.served_model_namereaches benchmark/eval clients but is omitted from nativetrtllm-serveworker commands. With locally mounted weights, clients can requestorg/modelwhile the server exposes/model.Forward the existing field as
--served_model_namefor native workers. Unset values preserve the current command and server default. This uses the existing TRT-LLM backend and configuration field, adds explicit/unset command-generation coverage, and updates the existing example and reference text. No schema, model-loading, precision, or performance settings change.