Register NV-Reason-CT in Medical AI Skills - #608
Conversation
Stage one catalog mapping under the existing Medical AI Skills component. Keep the registration draft pending public source availability and release requirements. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com>
mosheabr
left a comment
There was a problem hiding this comment.
Reviewed independently (verified against the source repo directly, not just the claims in the PR body).
What checks out:
- Source repo
NVIDIA-Medtech/medical-AI-skills— public, not archived, Apache-2.0. skills/nv-reason-ct/exists atdevwith the full artifact set:SKILL.md,evals/evals.json,skill-card.md,skill.oms.sig,BENCHMARK.md.BENCHMARK.mdshows a real bolded verdict: ✅ Overall verdict: PASS — Recommended for publication.components.d/medical-ai-skills.ymldiff is exactly the two lines described, correctly alphabetized,catalog_dir: nv-reason-ctunique across the whole catalog.- DCO, author-affiliation, content-integrity,
checkall green.
Blocker: SKILL.md frontmatter declares license: OpenMDW-1.1, backed by a matching per-directory LICENSE file (Open Model/Data/Weights License — typically used for model weights). Every sibling skill in this same component (nv-reason-cxr, nv-segment-ct, nv-generate-vae-finetune) uses license: Apache-2.0. OpenMDW-1.1 is not on the catalog's license menu (Apache 2.0 / CC-BY 4.0 / Dual).
This looks like a deliberate, weights-specific choice rather than a mistake, but it still needs to go through the license-menu exception process (or the content needs to be re-licensed onto the menu) before this can merge — can't wave through an off-menu license here.
Separately: source-onboarding is currently failing — per the PR description this ran before medical-AI-skills#68 merged and needs a re-trigger now that the path exists. That's a maintainer action, straightforward once the license question is resolved.
Requesting changes on the license question — please confirm intent and route through the exception process.
|
Thanks @mosheabr — the licensing change is now merged in medical-AI-skills#69. The skill's documentation, wrapper, and tests now use Apache-2.0. The frontmatter, per-skill LICENSE, manifest, source headers, and regenerated skill card agree. Separately obtained upstream model code, weights, and example data retain their existing terms; this change does not relicense those assets. Required source CI passed, the benchmark reports PASS — Recommended for publication, and a fresh signature was generated and independently verified with unsigned additions rejected. The merged I've updated this PR's description to follow the current template and record the merged source evidence. The registration is still just the two-line mapping, and the PR remains ready for review. Could you please rerun the stale |
mosheabr
left a comment
There was a problem hiding this comment.
License blocker resolved — verified independently: SKILL.md now declares Apache-2.0, per-directory LICENSE file matches, BENCHMARK.md still shows a real PASS verdict, and source-onboarding (re-triggered after the source fix) now passes clean along with all other checks. Approving.
Onboarding type
components.d/<slug>.ymlfile)For new product onboarding — author affirmations
This adds a skill to an existing component; the source repository and configured ref are unchanged. The owning team has confirmed that all required open-source release approvals are in place.
NVIDIA-Medtech/medical-AI-skills..agents/skills/orskills/path used for new entries (or existing path retained for legacy entries percomponents.d/<slug>.yml):skills/nv-reason-ct/.Reviewer checklist (OSS Skills PIC)
For the catalog reviewer to confirm:
components.d/<slug>.ymlentry valid (required fields, uniquecatalog_dir, path exists in source repo, filename slug matches name).SKILL.mdfrontmatter spec-compliant (at least one sampled).All PRs
git commit -s).Other context (for non-onboarding PRs)
Register
nv-reason-ctin the existingcomponents.d/medical-ai-skills.ymlcomponent. The entire diff remains two added YAML lines:The source remains
NVIDIA-Medtech/medical-AI-skillsatdev. No skill implementation, model assets, datasets, dependencies, or CI configuration are added to this catalog PR.Licensing review addressed in the source
medical-AI-skills#69 is merged into
devat1bc3f866f8f917b297095a82f23a2a09a1a66df9, addressing the licensing review.Validation and signing
fc3a1939d35fed72b83213371e7f9ab9a40e0c52; the trust anchor is unchanged.check, and NVSkills applicability checks pass.source-onboardingagainst the updateddevsource. Its current failed result predates availability of the source skill and the merged licensing/signing updates; it has not yet been refreshed. No gate has been disabled or bypassed.This PR remains ready for review, not draft. Catalog merge remains subject to refreshed onboarding results and maintainer review.
AI-assisted: Created with Codex/GPT at the user's request.