Skip to content

Register NV-Reason-CT in Medical AI Skills - #608

Merged
mosheabr merged 1 commit into
NVIDIA:mainfrom
wyli:codex/register-nv-reason-ct-20260923
Sep 25, 2026
Merged

mosheabr merged 1 commit into
NVIDIA:mainfrom
wyli:codex/register-nv-reason-ct-20260923

Conversation

@wyli

@wyli wyli commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change: add one skill to the existing Medical AI Skills component)

For new product onboarding — author affirmations

This adds a skill to an existing component; the source repository and configured ref are unchanged. The owning team has confirmed that all required open-source release approvals are in place.

  • Skills cleared for open source release by the owning team, with all required approvals in place.
  • License selected: Apache 2.0 / CC-BY 4.0 / Dual (Apache 2.0 + CC-BY 4.0). Specify: Apache 2.0 for the skill's documentation, wrapper, and tests.
  • No new license or new third-party component introduced beyond what the source repo already carries. This catalog PR adds only a mapping to the existing source skill; separately obtained upstream assets are not bundled.
  • Source repo is public and under an NVIDIA-owned GitHub org: NVIDIA-Medtech/medical-AI-skills.
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml): skills/nv-reason-ct/.

Reviewer checklist (OSS Skills PIC)

For the catalog reviewer to confirm:

  • Author confirmations above are checked.
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name).
  • SKILL.md frontmatter spec-compliant (at least one sampled).
  • No new license or third-party dependency introduced.

All PRs

  • All commits signed off with DCO (git commit -s).

Other context (for non-onboarding PRs)

Register nv-reason-ct in the existing components.d/medical-ai-skills.yml component. The entire diff remains two added YAML lines:

- path: skills/nv-reason-ct/
  catalog_dir: nv-reason-ct

The source remains NVIDIA-Medtech/medical-AI-skills at dev. No skill implementation, model assets, datasets, dependencies, or CI configuration are added to this catalog PR.

Licensing review addressed in the source

medical-AI-skills#69 is merged into dev at 1bc3f866f8f917b297095a82f23a2a09a1a66df9, addressing the licensing review.

  • The skill frontmatter, skill-local LICENSE, manifest, source headers, and regenerated skill card now declare Apache-2.0 for the skill.
  • Separately obtained upstream model code, weights, and example data retain their existing terms, including OpenMDW-1.1. They are not relicensed by this change or included in the catalog entry.

Validation and signing

  • Source PR Add NeMo AutoModel component #69 passed its required lint/tests, compliance, managed evaluation, and final signature-verification checks. Its regenerated benchmark reports PASS — Recommended for publication.
  • The fresh signature was independently verified against the NVIDIA trust anchor with unsigned additions rejected. The current merged skill directory is identical to that verified signed revision, fc3a1939d35fed72b83213371e7f9ab9a40e0c52; the trust anchor is unchanged.
  • On this catalog PR, DCO, author-affiliation, content-integrity, plugin check, and NVSkills applicability checks pass.
  • Maintainer action: rerun source-onboarding against the updated dev source. Its current failed result predates availability of the source skill and the merged licensing/signing updates; it has not yet been refreshed. No gate has been disabled or bypassed.

This PR remains ready for review, not draft. Catalog merge remains subject to refreshed onboarding results and maintainer review.

AI-assisted: Created with Codex/GPT at the user's request.

Stage one catalog mapping under the existing Medical AI Skills component. Keep the registration draft pending public source availability and release requirements.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
wyli marked this pull request as ready for review September 23, 2026 21:54
@wyli wyli changed the title Register NV-Reason-CT in Medical AI Skills (draft) Register NV-Reason-CT in Medical AI Skills Sep 23, 2026

@mosheabr mosheabr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed independently (verified against the source repo directly, not just the claims in the PR body).

What checks out:

  • Source repo NVIDIA-Medtech/medical-AI-skills — public, not archived, Apache-2.0.
  • skills/nv-reason-ct/ exists at dev with the full artifact set: SKILL.md, evals/evals.json, skill-card.md, skill.oms.sig, BENCHMARK.md.
  • BENCHMARK.md shows a real bolded verdict: ✅ Overall verdict: PASS — Recommended for publication.
  • components.d/medical-ai-skills.yml diff is exactly the two lines described, correctly alphabetized, catalog_dir: nv-reason-ct unique across the whole catalog.
  • DCO, author-affiliation, content-integrity, check all green.

Blocker: SKILL.md frontmatter declares license: OpenMDW-1.1, backed by a matching per-directory LICENSE file (Open Model/Data/Weights License — typically used for model weights). Every sibling skill in this same component (nv-reason-cxr, nv-segment-ct, nv-generate-vae-finetune) uses license: Apache-2.0. OpenMDW-1.1 is not on the catalog's license menu (Apache 2.0 / CC-BY 4.0 / Dual).

This looks like a deliberate, weights-specific choice rather than a mistake, but it still needs to go through the license-menu exception process (or the content needs to be re-licensed onto the menu) before this can merge — can't wave through an off-menu license here.

Separately: source-onboarding is currently failing — per the PR description this ran before medical-AI-skills#68 merged and needs a re-trigger now that the path exists. That's a maintainer action, straightforward once the license question is resolved.

Requesting changes on the license question — please confirm intent and route through the exception process.

@wyli

wyli commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

Thanks @mosheabr — the licensing change is now merged in medical-AI-skills#69.

The skill's documentation, wrapper, and tests now use Apache-2.0. The frontmatter, per-skill LICENSE, manifest, source headers, and regenerated skill card agree. Separately obtained upstream model code, weights, and example data retain their existing terms; this change does not relicense those assets.

Required source CI passed, the benchmark reports PASS — Recommended for publication, and a fresh signature was generated and independently verified with unsigned additions rejected. The merged dev skill directory matches the verified signed contents exactly.

I've updated this PR's description to follow the current template and record the merged source evidence. The registration is still just the two-line mapping, and the PR remains ready for review. Could you please rerun the stale source-onboarding check against the current source and re-review the licensing blocker?

@mosheabr mosheabr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License blocker resolved — verified independently: SKILL.md now declares Apache-2.0, per-directory LICENSE file matches, BENCHMARK.md still shows a real PASS verdict, and source-onboarding (re-triggered after the source fix) now passes clean along with all other checks. Approving.

@mosheabr
mosheabr merged commit a6c9650 into NVIDIA:main Sep 25, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants