Adopt CUDA stream compatibility accessors - #3136
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
72b7fbd to
5fbe443
Compare
|
Validated this preparation branch against RMM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughChangesCUDA stream handle migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This updates CUDA stream compatibility accessors while preserving existing stream behavior and public interfaces; no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 26.73% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 101 functions across 66 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
CI exposed benchmark targets that the default local build did not compile. The preparation branch now adds the missing raw-stream accessors at those benchmark boundaries (
|
Summary
Use the
get()andsync()compatibility aliases added in RMM #2537. These spellings are shared byrmm::cuda_stream_viewandcuda::stream_ref.This preserves existing stream types and public APIs while extracting mechanical accessor updates from the broader stream migration. It is independently buildable without RMM #2372 and leaves the migration PR focused on actual type and signature changes.
This updates raw CUDA, library, kernel-launch, and legacy API boundaries throughout RAFT and uses the CUDA stream umbrella header where stream definitions are required. Existing
rmm::cuda_stream_viewreturn types remain unchanged; their migration stays in RAFT #3129.