Add unit test for torch compile #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graph breaks in model code are detrimental to performance when models are compiled. Add a test for fullgraph compile of models. For models where fullgraph capture works (fno, songunet), this test will ensure that model code updates dont break it. For the other models (healpix, graphcast) this test shows graphbreaks so they can be fixed. Signed-off-by: Ramu Ramamurthy <[email protected]>
added 2 commits
May 12, 2025 15:53
Signed-off-by: Ramu Ramamurthy <[email protected]>
…nemo into add-fullgraph-compile-test
|
LGTM! |
Signed-off-by: Ramu Ramamurthy <[email protected]>
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Unit tests for optimizations are missing a test for torch compile.
This test helps detect Graph breaks in model code which are detrimental to performance when models are compiled. For models where fullgraph capture works (fno, songunet), this test will ensure that model code updates dont break it. For other models this test shows graphbreaks so they can be fixed. (dlwp_healpix_unet - graphbreaks due to nvtx annotations, graphcast - graphbreaks due cpu tensors etc)
Checklist
Dependencies