Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ReGen model release #810

Merged
merged 6 commits into from
Mar 20, 2025

Conversation

pzharrington
Copy link
Collaborator

@pzharrington pzharrington commented Mar 14, 2025

Modulus Pull Request

Description

Adds the ReGen model (https://arxiv.org/abs/2406.16947) training and inference code as an example, including reproducibility for paper figures.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

Additional dependencies for this example specified in requirements.txt

@pzharrington pzharrington self-assigned this Mar 14, 2025
@pzharrington
Copy link
Collaborator Author

/blossom-ci

Copy link
Collaborator

@nbren12 nbren12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to delete the pdfs though. There are definitely a lot of follow-up focused on usability, but there probably isn't much point to making the example inference usable until we release a checkpoint.

Copy link
Collaborator

@CharlelieLrt CharlelieLrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few comments, mostly about:

  1. A few binary files. I'm not sure if those are required for the paper submission but it would be better not to have them in the main
  2. Some utilities that are already implemented in modulus, which could be re-used if possible.
  3. The model that has many poor performance operations. This could re-use many of the layers of the SongUNet defined for CorrDiff.
    I understand it's for paper submission, so feel free to address these later in another PR. Otherwise, LGTM.

@pzharrington
Copy link
Collaborator Author

@CharlelieLrt thanks for the review, I agree with all your comments. As Noah mentioned most of this is in there for direct paper reproducibility/journal submission -- I have a version of the training loop etc in development that uses the physicsnemo SongUNet and other utils, just got stuck in the process of verifying accuracy but we can hopefully pick that up again after this is merged.

Also thanks @nbren12 for the comments -- should be addressed now.

@pzharrington
Copy link
Collaborator Author

/blossom-ci

@pzharrington
Copy link
Collaborator Author

/blossom-ci

2 similar comments
@pzharrington
Copy link
Collaborator Author

/blossom-ci

@ktangsali
Copy link
Collaborator

/blossom-ci

@pzharrington
Copy link
Collaborator Author

/blossom-ci

@pzharrington pzharrington merged commit 878fd04 into NVIDIA:main Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants