-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial ReGen model release #810
Conversation
/blossom-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be nice to delete the pdfs though. There are definitely a lot of follow-up focused on usability, but there probably isn't much point to making the example inference usable until we release a checkpoint.
examples/weather/regen/paper_figures/evenmore_random_val_stations.npy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few comments, mostly about:
- A few binary files. I'm not sure if those are required for the paper submission but it would be better not to have them in the
main
- Some utilities that are already implemented in modulus, which could be re-used if possible.
- The model that has many poor performance operations. This could re-use many of the layers of the SongUNet defined for CorrDiff.
I understand it's for paper submission, so feel free to address these later in another PR. Otherwise, LGTM.
@CharlelieLrt thanks for the review, I agree with all your comments. As Noah mentioned most of this is in there for direct paper reproducibility/journal submission -- I have a version of the training loop etc in development that uses the physicsnemo Also thanks @nbren12 for the comments -- should be addressed now. |
/blossom-ci |
/blossom-ci |
2 similar comments
/blossom-ci |
/blossom-ci |
/blossom-ci |
Modulus Pull Request
Description
Adds the ReGen model (https://arxiv.org/abs/2406.16947) training and inference code as an example, including reproducibility for paper figures.
Checklist
Dependencies
Additional dependencies for this example specified in
requirements.txt