Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC Checkpointing Changes #789

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

MSC Checkpointing Changes #789

wants to merge 36 commits into from

Conversation

chris-hawes
Copy link

@chris-hawes chris-hawes commented Feb 11, 2025 •
edited
Loading

Modulus Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

oguzerdogmus
oguzerdogmus reviewed Feb 19, 2025
View reviewed changes
akshaysubr
akshaysubr reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@akshaysubr akshaysubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Had a few stylistic comments and only one other important comment about unifying the filesystem abstractions used in the code base.

akshaysubr
akshaysubr reviewed Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@akshaysubr akshaysubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Not sure why this is still a draft PR though. Will do a short review once its not draft and approve.

@chris-hawes chris-hawes marked this pull request as ready for review March 11, 2025 23:01
@akshaysubr akshaysubr requested a review from NickGeneva March 11, 2025 23:11
akshaysubr
akshaysubr approved these changes Mar 11, 2025
View reviewed changes
@NickGeneva
Copy link
Collaborator

LGTM, a nice generalization to fsspec. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzerdogmus oguzerdogmus oguzerdogmus left review comments

@NickGeneva NickGeneva NickGeneva approved these changes

@akshaysubr akshaysubr akshaysubr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chris-hawes @NickGeneva @akshaysubr @oguzerdogmus