-
Notifications
You must be signed in to change notification settings - Fork 500
Fix README links in transolver and domino examples #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update links to physicsnemo-curator examples in DoMINO and Transolver READMEs. - Update link to CachedDoMINODataset and path reference for cache_data.py script.
Greptile OverviewGreptile SummaryThis PR updates documentation links in the DoMINO and Transolver example READMEs to reflect the reorganization of PhysicsNeMo-Curator documentation. All links that previously pointed to a DoMINO-specific README (
All changes are documentation-only with no functional code modifications. The new links have been verified and are accessible. Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
|
@saikrishnanc-nv @coreyjadams could you review? |
coreyjadams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dran-dev for some fixes!
|
LGTM! |
|
/blossom-ci |
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.