Skip to content

Conversation

@dran-dev
Copy link
Contributor

@dran-dev dran-dev commented Dec 1, 2025

PhysicsNeMo Pull Request

Description

  • Update links to physicsnemo-curator examples in DoMINO and Transolver READMEs.
  • Update link to CachedDoMINODataset and path reference for cache_data.py script in DoMINO README.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

- Update links to physicsnemo-curator examples in DoMINO and Transolver READMEs.
- Update link to CachedDoMINODataset and path reference for cache_data.py script.
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 1, 2025

Greptile Overview

Greptile Summary

This PR updates documentation links in the DoMINO and Transolver example READMEs to reflect the reorganization of PhysicsNeMo-Curator documentation. All links that previously pointed to a DoMINO-specific README (examples/external_aerodynamics/domino/README.md) now correctly reference the general external aerodynamics README (examples/external_aerodynamics/README.md). Additionally, the DoMINO README updates:

  • The CachedDoMINODataset class link to point to the correct line number (L1056 instead of L1250)
  • The path reference for the cache_data.py script to include the src/ prefix

All changes are documentation-only with no functional code modifications. The new links have been verified and are accessible.

Important Files Changed

File Analysis

Filename Score Overview
examples/cfd/external_aerodynamics/domino/README.md 5/5 Updated links to PhysicsNeMo-Curator documentation (moved from domino-specific to general external_aerodynamics README), fixed CachedDoMINODataset line reference from L1250 to L1056, and corrected path to cache_data.py script from root to src/ directory
examples/cfd/external_aerodynamics/transolver/README.md 5/5 Updated links to PhysicsNeMo-Curator documentation (changed from domino-specific path to general external_aerodynamics README path)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@dran-dev
Copy link
Contributor Author

dran-dev commented Dec 1, 2025

@saikrishnanc-nv @coreyjadams could you review?

Copy link
Collaborator

@coreyjadams coreyjadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dran-dev for some fixes!

@saikrishnanc-nv
Copy link
Collaborator

LGTM!

@saikrishnanc-nv
Copy link
Collaborator

/blossom-ci

@saikrishnanc-nv saikrishnanc-nv merged commit 24155c6 into NVIDIA:main Dec 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants