Skip to content

Conversation

@ghasemiAb
Copy link

@ghasemiAb ghasemiAb commented Aug 1, 2025

PhysicsNeMo Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

get_volume_data is now compatible with VTK point and cell data, modified utils.py for DoMINO
mean_std_scaling modified in domino_datapipe.py
@ghasemiAb
Copy link
Author

@RishikeshRanade can you please review thr PR. I do not haev right to select reviwer @ktangsali

@RishikeshRanade RishikeshRanade self-requested a review August 1, 2025 17:39
Copy link
Collaborator

@RishikeshRanade RishikeshRanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update changelog.md and rebase with main.

print("Using existing PointData.")
fields = get_fields(point_data, variable_names)

Args:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this docstring section back to the get_volume_data function

@RishikeshRanade
Copy link
Collaborator

/blossom-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants