Extract FileMode from host path if possible #960
Conversation
internal/edits/device.go
Outdated
| dn, err := devices.DeviceFromPath(path, "rwm") | ||
| if err != nil { | ||
| // return nil, fmt.Errorf("failed to get device information for %q: %w", path, err) | ||
| return nil |
There was a problem hiding this comment.
To what will nil translate to in the spec? => 0 ?
There was a problem hiding this comment.
nil would be the current behaviour. In the case of runc this is filled in by the runtime and read from the host. In the case of kata, this would be 0 as you've observed.
There was a problem hiding this comment.
The interface is the CDI spec, so how does runc know this value is nil? It is not encoded in the CDI spec.
There was a problem hiding this comment.
Actually, maybe runc is not the correct reference here. For regular devices, a higher-level runtime such as containerd also extracts the FileMode (see https://github.com/containerd/containerd/blob/9deb0b8f748ee038dfd48c51d7aee6b55e34e9c1/pkg/oci/utils_unix.go#L142). This is not done for CDI devices since the code from https://github.com/cncf-tags/container-device-interface/blob/012c8be38d9444f08b7e6eeedbcddd733adf8632/pkg/cdi/container-edits_unix.go#L60 is used for this instead.
This means that for OCI devices created from a CDI spec, this field is nil if unspecified, whereas for "regular" devices this field is populated from the device node on the host.
@klihub do you know why we elected to not add information other than the Major and Minor numbers to the devices in CDI?
There was a problem hiding this comment.
@elezar Do you mean what is the reason for not filling in any other missing information wrt. the CDI Spec DeviceNode than type, major, and minor ? TBH, I don't recall any specifics, but I suspect it's only because that's the minimum working implementation.
elezar
force-pushed
the
add-additional-device-node-information
branch
from
eb70273 to
4dae5ae
Compare
elezar
force-pushed
the
add-additional-device-node-information
branch
from
4dae5ae to
0a16c93
Compare
Pull Request Test Coverage Report for Build 15758891592Details
💛 - Coveralls |
elezar
force-pushed
the
add-additional-device-node-information
branch
from
0a16c93 to
85adc3f
Compare
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
bot
added
the
lifecycle/stale
elezar
added
lifecycle/frozen
and removed
lifecycle/stale
elezar
force-pushed
the
add-additional-device-node-information
branch
from
85adc3f to
100ce7e
Compare
This change extracts the required information from the host device node if available. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
add-additional-device-node-information
branch
from
100ce7e to
f7f0c3e
Compare
4 participants
This change extracts the filemode from the host device nodes for CDI device specs. This allows the spec to be used in cases where a low-level runtime such as
runcdoes not query the existing device node in the same way.